[ui-01] Work with Wheather ui branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui-wheatherapi/src/main/java/com/weatherapi/ui/pages/HistoryPage.java
Outdated
Show resolved
Hide resolved
ui-wheatherapi/src/main/java/com/weatherapi/ui/pages/TodayPage.java
Outdated
Show resolved
Hide resolved
ui-wheatherapi/src/main/java/com/weatherapi/ui/pages/TomorrowPage.java
Outdated
Show resolved
Hide resolved
ui-wheatherapi/src/test/java/com/weatherapi/ui/tests/TomorrowWeather.java
Outdated
Show resolved
Hide resolved
|
You are working with UI part but your PR name called "[ui-01] Work with Wheather api branch" it should be "[ui-01] Work with Wheather ui branch" |
| return this; | ||
| } | ||
|
|
||
| public HistoryPage checkHistoryPageElements(){ |
There was a problem hiding this comment.
You should add parameter in method public HistoryPage checkHistoryPageElements(){
| private final SelenideElement loginPage = $("[href=\"/login.aspx\"]"); | ||
| public final String loginButton = "Login"; | ||
|
|
||
| public MainPage open() { |
| return new LoginPage(); | ||
| } | ||
|
|
||
| public MainPage checkUserLogout(){ |
| return this; | ||
| } | ||
|
|
||
| public TomorrowPage checkTomorrowPageElements(){ |
Comment on lines
+13
to
+19
| private final String MAIN_PAGE = "https://www.weatherapi.com/weather/"; | ||
| private final String USER_EMAIL = "[email protected]"; | ||
| private final String USER_PASSWORD = "f2H*Jap*M6@7/d_"; | ||
| private final String personalAccountText = "Welcome Back\n"; | ||
| private final String WRONG_USER_EMAIL = "[email protected]"; | ||
| private final String WRONG_USER_PASSWORD = "09876TYUI54321i"; | ||
| private final String WARNING_MESSAGE= "Your login attempt was not successful. Please try again."; |
There was a problem hiding this comment.
Move all this data in separate class and reuse in tests
Comment on lines
+13
to
+15
| private final String USER_EMAIL = "[email protected]"; | ||
| private final String USER_PASSWORD = "f2H*Jap*M6@7/d_"; | ||
| private final String MAIN_PAGE = "https://www.weatherapi.com/"; |
| import static com.codeborne.selenide.Selenide.open; | ||
|
|
||
| public class TodaysWeatherForecasTest { | ||
| private final String MAIN_PAGE = "https://www.weatherapi.com/weather/"; |
| import static com.codeborne.selenide.Selenide.open; | ||
|
|
||
| public class TomorrowWeather { | ||
| private final String MAIN_PAGE = "https://www.weatherapi.com/weather/"; |
| public class TomorrowWeather { | ||
| private final String MAIN_PAGE = "https://www.weatherapi.com/weather/"; | ||
|
|
||
| @BeforeClass |
There was a problem hiding this comment.
think about moving this configuration in separate class
Kofanskih
changed the title
Comment on lines
+27
to
+32
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| <version>7.10.2</version> | ||
| <scope>test</scope> | ||
| </dependency> |
Comment on lines
+34
to
+51
| <dependency> | ||
| <groupId>net.datafaker</groupId> | ||
| <artifactId>datafaker</artifactId> | ||
| <version>2.4.2</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.36</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| <version>7.10.2</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.