Better IguanaTV #433
Closed
Better IguanaTV #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colorize chain symbols Cut some message bits (to remove non-meaningful duplicates) Reword some things for meaning Reorder some messages for consistency
A little less screen clutter
ca333
reviewed
Oct 30, 2022
Co-authored-by: Kadan Stadelmann <[email protected]>
smk762
previously approved these changes
May 27, 2023
ca333
previously approved these changes
May 29, 2023
|
Thanks for your contribution. The idea to colorize iguana output is an interesting one and I appreciate your creativity. However, I believe that introducing colors may not be beneficial for every user. Preferences on color schemes vary significantly and in some cases, it can be even distracting. Although your PR doesn't introduce any negative changes, it also doesn't provide a universally agreed upon enhancement to our repository. Hence, I propose closing this PR for now. If the wider community demonstrates significant interest and we receive, say, 20 likes or more from the notary node operators, we can certainly revisit this discussion. Thank you again for your effort, and I encourage you to continue contributing to our code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A take off #424 that adds color, begins to order prints in a consistent manner, and removes some duplicate prints (both in number and content).