-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better IguanaTV #433
Better IguanaTV #433
Conversation
Colorize chain symbols Cut some message bits (to remove non-meaningful duplicates) Reword some things for meaning Reorder some messages for consistency
A little less screen clutter
Co-authored-by: Kadan Stadelmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution. The idea to colorize iguana output is an interesting one and I appreciate your creativity. However, I believe that introducing colors may not be beneficial for every user. Preferences on color schemes vary significantly and in some cases, it can be even distracting. Although your PR doesn't introduce any negative changes, it also doesn't provide a universally agreed upon enhancement to our repository. Hence, I propose closing this PR for now. If the wider community demonstrates significant interest and we receive, say, 20 likes or more from the notary node operators, we can certainly revisit this discussion. Thank you again for your effort, and I encourage you to continue contributing to our code base. |
A take off #424 that adds color, begins to order prints in a consistent manner, and removes some duplicate prints (both in number and content).