Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual GLEEC on main server #566

Closed
wants to merge 8 commits into from
Closed

Dual GLEEC on main server #566

wants to merge 8 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 29, 2024

Replaces #564
Merge #565 first

@smk762 smk762 requested review from gcharang, DeckerSU and cipig August 29, 2024 09:29
Copy link
Contributor

@TheComputerGenie TheComputerGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While editing the 3rd party launch script makes sense, telling ops to launch it on main server does not.

cd iguana
./m_notary_build
./m_notary_main
./m_notary_3rdparty
Copy link
Contributor

@TheComputerGenie TheComputerGenie Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./m_notary_3rdparty shouldn't be here.

cd iguana
./m_notary_build
./m_notary_main
./m_notary_3rdparty
Copy link
Contributor

@TheComputerGenie TheComputerGenie Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./m_notary_3rdparty shouldn't be here.

DeckerSU
DeckerSU previously approved these changes Sep 16, 2024
Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest two changes introduced in the last two commits, LGTM.

@DeckerSU
Copy link
Contributor

DeckerSU commented Sep 24, 2024

Update: Before launching the new GLEEC chain, we need to first accept this PR#629. Notaries, as well as all other new GLEEC users (such as explorers, Electrum nodes, etc.), should use a daemon that includes this fix.

@DeckerSU DeckerSU self-requested a review September 24, 2024 23:40
@smk762
Copy link
Collaborator Author

smk762 commented Sep 30, 2024

closing, combined into #563

@smk762 smk762 closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants