feat(tendermint): staking/delegation #2322
Open
+443
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
changed the title
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
tendermint-delegation
branch
from
081df90 to
4012550
Compare
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
tendermint-delegation
branch
4 times, most recently
from
8145b90 to
16dad85
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
tendermint-delegation
branch
2 times, most recently
from
f67185a to
1dd2b73
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
tendermint-delegation
branch
from
4340e37 to
0f08e05
Compare
laruh
requested changes
Jan 23, 2025
shamardy
previously approved these changes
Jan 23, 2025
Signed-off-by: onur-ozkan <[email protected]>
borngraced
requested changes
Jan 24, 2025
| &account_info, | ||
| fee, | ||
| timeout_height, | ||
| memo.clone(), |
There was a problem hiding this comment.
not directly related but I think it worth mention that we can avoid cloning memo everywhere.
We can pass ref str to tx::Body::new(vec![tx_payload], &memo, timeout_height as u32); like here
dimxy
reviewed
Jan 26, 2025
| &self, | ||
| withdraw_from: Option<WithdrawFrom>, | ||
| ) -> Result<(AccountId, Option<H256>), WithdrawError> { | ||
| ) -> Result<(AccountId, Option<H256>), String> { |
There was a problem hiding this comment.
Are we not generally striving to avoid String errors (in favour of always typed errors)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tendermint protocol support on
add_delegationRPC, and extends tendermint transaction history implementation to support delegation transactions.Next is to do the same for undelegation on
remove_delegation.TODO: File a documentation issue on https://github.com/KomodoPlatform/komodo-docs-mdx