-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/nft methods #317
base: dev
Are you sure you want to change the base?
Update/nft methods #317
Conversation
Indicated proxy_auth is optional and defaults to false.
Readded BSC chain
fixed nft_req
Created enable_nft file (based on enable_erc20)
Added NftProvider object to common structures
Changed activation_param definition to be a standard NftProvider object
NFT RPC Methods Docs update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, 1st review iteration
src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/common_structures/nfts/index.mdx
Outdated
Show resolved
Hide resolved
Preview for merge commit: 7019a83, available on cloudflare at: https://5b965a8c.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 7019a83, available on cloudflare at: https://8960ebf3.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 3c6541f, available on cloudflare at: https://c3b10cf0.komodo-docs.pages.dev/en/docs/ |
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
I have one note
| maker\_swap\_v2\_contract | string | Address for the maker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| taker\_swap\_v2\_contract | string | Address for the taker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| nft\_maker\_swap\_v2\_contract | string | Address for the maker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| nft\_taker\_swap\_v2\_contract | string | Address for the taker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont have nft taker smart contact
field in Komodo DeFi project and such solidity contract in Etomic Swap project.
Right now we are focusing on Nft maker swap operations, where Maker is Nft owner.
"maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
"taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
"nft_maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
"nft_taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nft_taker_swap_v2_contract also should be removed according to the comment above.
Continues from #270