Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rbac) add permission to update kongpluginbindings/status #743

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:
Add permissions to update kongpluginbindings/status in RBAC for KongPluginBinding reconcilers to update status.
Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey requested a review from a team as a code owner October 14, 2024 09:13
@randmonkey randmonkey self-assigned this Oct 14, 2024
@randmonkey randmonkey added this to the KGO v1.4.x milestone Oct 14, 2024
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. How did you spot this? Did you encounter an error somewhere?

controller/konnect/reconciler_kongplugin_rbac.go Outdated Show resolved Hide resolved
@randmonkey
Copy link
Contributor Author

Nice find. How did you spot this? Did you encounter an error somewhere?

I saw KonnectPluginBinding is reconciled but plugins are not really created in Konnect in writing guide page of KongPluginBinding. After adding logs in reconciler at the place of processing errors in handleControlPlaneRef, I found that the RBAC was not properly configured. Should we add some logs in reconciler when some error happened but no further reconciler error is returned?

@randmonkey randmonkey enabled auto-merge (squash) October 14, 2024 09:44
@pmalek
Copy link
Member

pmalek commented Oct 14, 2024

I saw KonnectPluginBinding is reconciled but plugins are not really created in Konnect in writing guide page of KongPluginBinding. After adding logs in reconciler at the place of processing errors in handleControlPlaneRef, I found that the RBAC was not properly configured. Should we add some logs in reconciler when some error happened but no further reconciler error is returned?

Yes, if possible. Ideally we'd add tests that should check that. This is yet another gap in RBAC testing: https://kongstrong.slack.com/archives/C011RQPHDC7/p1728658205054639

@randmonkey randmonkey merged commit 81dc7a4 into main Oct 14, 2024
21 checks passed
@randmonkey randmonkey deleted the fix/add_kongpluginbinding_status_permission branch October 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants