fix: set DataPlane's ExternalTrafficPolicy on updates and patches #750
+119
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
fix-dataplane-external-policy-patch
branch
from
b5c10f9
to
4af5923
Compare
pmalek
force-pushed
the
fix-dataplane-external-policy-patch
branch
from
4af5923
to
57548bc
Compare
czeslavo
approved these changes
Oct 17, 2024
Co-authored-by: Grzegorz Burzyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#241 added support for setting
ExternalTrafficPolicyonDataPlaneingressService.It missed an important aspect of it: comparing the policy on existing
Services.This PR fixes this.
Special notes for your reviewer:
Another consequence of not having #500 implemented and still using error prone "per field comparison" approach.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes