fix(konnect): handle KongRoute conflict on creation #752
+432
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
konnect-uid-adoption-routes
branch
from
1741f27
to
2b6fbdb
Compare
pmalek
force-pushed
the
konnect-uid-adoption-routes
branch
from
2b6fbdb
to
c87d1dd
Compare
randmonkey
reviewed
Oct 18, 2024
| GetID() *string | ||
| } | ||
|
|
||
| func fromSliceToSlice[T any]( |
There was a problem hiding this comment.
Could we some comments and give it a clearer name? fromSliceToSlice is really hard to understand.
| @@ -126,7 +126,7 @@ func Create[ | |||
|
|
|||
| switch { | |||
| case errors.As(err, &errConflict) || | |||
| // Service API returns 400 for conflicts | |||
| // ControlPlane resource APIs return 400 for conflicts | |||
| errSdkBody.Code == 3 && errSdkBody.Message == "data constraint error": | |||
There was a problem hiding this comment.
Could we define some function or constant to eliminate the magic number and string here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up on #749 for
KongRoute.