Skip to content

Commit

Permalink
fix(controller): reconcile secrets having kongCredType in data (#6400)
Browse files Browse the repository at this point in the history
* reconcile secrets having kongCredType in data

* update changelog
  • Loading branch information
randmonkey authored Aug 16, 2024
1 parent 7e18ff8 commit 0ece9e1
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ Adding a new version? You'll need three changes:
- [0.0.5](#005)
- [0.0.4 and prior](#004-and-prior)

## Unreleased

### Fixed

- Reconcile `Secret`s with `kongCredType` in data implying that the secrets are
used as Kong credentials.
[#6400](https://github.com/Kong/kubernetes-ingress-controller/pull/6400)

## [2.12.5]

> Release date: 2024-06-25
Expand Down
5 changes: 5 additions & 0 deletions internal/controllers/configuration/secret_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ func (r *CoreV1SecretReconciler) shouldReconcileSecret(obj client.Object) bool {
return true
}

// reconcile secrets used as Kong credentials.
if _, ok := secret.Data["kongCredType"]; ok {
return true
}

referred, err := r.ReferenceIndexers.ObjectReferred(secret)
if err != nil {
r.Log.Error(err, "failed to check whether secret referred",
Expand Down

0 comments on commit 0ece9e1

Please sign in to comment.