fix(request): build request body by operation payload field #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report2 tests 2 ✅ 0s ⏱️ Results for commit 575df09. ♻️ This comment has been updated with latest results. |
|
@Tieske Could you please help check this? Thanks in advance! |
outsinre
previously approved these changes
Aug 2, 2024
tzssangglass
previously approved these changes
Aug 2, 2024
tzssangglass
approved these changes
Aug 2, 2024
catbro666
approved these changes
Aug 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up fix for #120 .
The PR modifies the request build again with the following changes: when the
payloadfield is specified inside the input schema, the request body will be built based on the parameter that specified by thepayloadfield.This behavior imitates the behavior defined in
aws-sdk-js: https://github.com/aws/aws-sdk-js/blob/02153340ce052614c5437fe46ab1f49bfd8483f7/lib/protocol/rest_json.js#L24-L41as well as https://github.com/aws/aws-sdk-js/blob/02153340ce052614c5437fe46ab1f49bfd8483f7/lib/protocol/rest_xml.js#L10-L26
Issues
This fixes the breaking change behavior found here: Kong/kong#13433
FTI-6138