fix(request): remove unescape operation for user-input query params when building canonical querystring #132
+149
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen building canonical querystring
Luacheck Report4 tests 4 ✅ 0s ⏱️ Results for commit d70bf0e. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a 403 issue when user-input query params contains some reserved characters for urlencode.
https://konghq.atlassian.net/browse/FTI-6288 is the original report where user failed to call SNS service "Publish" operation to send a message with "+" or "%".
This PR fixes the issue that when the request is being built, query params in AWS API doc's
requestUriwill be unescaped, and user-input query params will not getting unescaped when signing request.