chore(*): support SDK_VERSION_TAG env var and fetch latest tag in CI #72
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windmgc
force-pushed
the
chore-api-version-bump
branch
from
2c67137
to
bfcc9cf
Compare
|
this is tricky. This library generates its methods from the metadata. So top update to a newer version of the meta data, we should also verify any code chnages in the JS sdk over the same version bumps. ANd then ensure we follow those here as well, otherwise we might introduce bugs. That said. I think I'd be in favour of updating the lib to the 3.x version of the JS sdk, since the 2.x is going EOL, see https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/ see internal KAG-3834 |
|
This PR hasn't been picked up for a long time, but yes I did encounter some problems when upgrading to the latest SDK version and running tests. I'm gonna close this one and we can track further work in KAG ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using
SDK_VERSION_TAGenvironment variable to runupdate_api, and let CI use latestaws-sdk-jsrelease tag for testing.Fix #56