Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/napi #50

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

Chore/napi #50

wants to merge 34 commits into from

Conversation

jackkav
Copy link

@jackkav jackkav commented Aug 27, 2024 •
edited
Loading

migrate NaN to napi

goal: migrating to napi so we when we build node-libcurl on a specific major version would run correctly in subsequent major versions without recompilation.

  • run napi migration script
  • fix initial errors
  • fix errors where api is now different (e.g. nan calls that dont exist, target is no longer a thing, ...)
  • ??

useful docs and examples

@jackkav jackkav force-pushed the chore/napi branch 2 times, most recently from 0480aa1 to fa47410 Compare August 29, 2024 09:53
@jackkav jackkav force-pushed the chore/napi branch 2 times, most recently from 9b168e5 to 3c8451e Compare September 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkav @filfreire