Nuketrino (xivanalysis#1079)

.browserslistrc

@@ -0,0 +1,4 @@
+>0.2%
+not dead
+not ie <= 11
+not op_mini all

.circleci/config.yml

@@ -2,7 +2,7 @@
 defaults: &defaults
   working_directory: /tmp/xiva-client
   docker:
-    - image: circleci/node:10
+    - image: cimg/node:lts
 
 version: 2
 jobs:
@@ -31,11 +31,7 @@ jobs:
           at: /tmp
       - run:
           name: Lint
-          # I love how tslint needs its hand held with making directories
-          command: |
-            yarn lint:js --format junit -o reports/eslint/results.xml
-            mkdir -p reports/tslint
-            yarn lint:ts --format junit -o reports/tslint/results.xml
+          command: yarn lint --format junit -o reports/eslint/results.xml
       - run:
           name: Ensure extract
           command: |

.env

@@ -1,5 +1,3 @@
-NODE_SRC_PATH=src/
-
 REACT_APP_SENTRY_DSN=https://[email protected]/1218345
 REACT_APP_FFLOGS_V1_BASE_URL=https://xivanalysis.com/proxy/fflogs/
 # REACT_APP_FFLOGS_V1_API_KEY=[UNUSED]

.eslintrc.js

@@ -1,3 +1,176 @@
-const neutrino = require('neutrino')
+module.exports = {
+	root: true,
+	extends: [
+		'eslint:recommended',
+		'plugin:@typescript-eslint/recommended',
+		'plugin:react/recommended',
+	],
 
-module.exports = neutrino().eslintrc()
+	// TODO: Might need to use both babel-eslint and typescript-eslint depending on filetype?
+	parser: '@typescript-eslint/parser',
+	plugins: [
+		'@typescript-eslint',
+		'react',
+		'react-hooks',
+		// TODO: Remove this, bring rule into xiva/xiva repo.
+		'@xivanalysis',
+	],
+
+	settings: {
+		react: {version: 'detect'},
+	},
+
+	env: {
+		browser: true,
+		commonjs: true,
+		es6: true,
+	},
+
+	globals: {
+		// process.env injected by webpack
+		process: true,
+	},
+
+	rules: {
+		// #region Migration required
+		// TODO: Migrate disable to JS-only
+		'@typescript-eslint/explicit-module-boundary-types': 'off',
+		// TODO: Enable
+		'@typescript-eslint/no-inferrable-types': 'off',
+		// TODO: Enable
+		'@typescript-eslint/no-explicit-any': 'off',
+		// TODO: Enable for JS.
+		// TODO: Enable for TS, will likely need arg pattern allow for base classes &c
+		'@typescript-eslint/no-unused-vars': 'off',
+		// TODO: Should probably enable
+		'no-case-declarations': 'off',
+		// TODO: Enable?
+		'no-prototype-builtins': 'off',
+		// TODO: Enable
+		'@typescript-eslint/no-non-null-assertion': 'off',
+		// TODO: Enable, might need tweaks
+		'@typescript-eslint/ban-types': 'off',
+		// TODO: Enable
+		'@typescript-eslint/no-empty-function': 'off',
+		// TODO: Consider?
+		'@typescript-eslint/ban-ts-comment': 'off',
+		// TODO: Hmm??
+		'@typescript-eslint/no-this-alias': 'off',
+		// TODO: ts-eslint docs recc. turning this off. probably enable for js only?
+		'no-undef': 'off',
+		// TODO: Enable for at least .log (debug exists)
+		'no-console': 'off',
+		// TODO: Enable at _minimum_ {default: 'array-simple'}
+		'@typescript-eslint/array-type': 'off',
+		// #endregion
+
+		'array-bracket-spacing': 'warn',
+		'block-spacing': 'warn',
+		'brace-style': ['error', '1tbs', {allowSingleLine: true}],
+		'comma-dangle': ['error', 'always-multiline'],
+		'comma-spacing': 'warn',
+		'comma-style': 'warn',
+		'computed-property-spacing': 'warn',
+		'curly': ['error', 'all'],
+		'default-case': 'off',
+		'dot-notation': 'error',
+		'eol-last': 'error',
+		'eqeqeq': ['error', 'smart'],
+		'func-call-spacing': 'warn',
+		'indent': ['error', 'tab'],
+		'jsx-quotes': 'error',
+		'key-spacing': ['warn', {mode: 'minimum'}],
+		'keyword-spacing': 'warn',
+		'linebreak-style': ['error', 'unix'],
+		'newline-per-chained-call': ['warn', {ignoreChainWithDepth: 3}],
+		'new-parens': 'error',
+		'no-alert': 'error',
+		'no-duplicate-imports': 'error',
+		'no-else-return': ['error', {allowElseIf: false}],
+		'no-implicit-globals': 'error',
+		'no-lonely-if': 'error',
+		'no-magic-numbers': ['warn', {
+			ignoreArrayIndexes: true,
+			ignore: [
+				-1,   // Used by a lot of stuff (inc stdlib) to represent not found
+				0,    // I prefer .length===0 checks most of the time
+				1,    // THE NUMBER ONE
+				2,    // Often used for number formatting and similar
+				100,  // Percents
+				1000, // Lots of translation between s and ms
+			],
+		}],
+		'no-multiple-empty-lines': ['warn', {max: 1, maxBOF: 0, maxEOF: 1}],
+		'no-return-await': 'error',
+		'no-trailing-spaces': 'error',
+		'no-unneeded-ternary': 'error',
+		'no-useless-rename': 'error',
+		'no-var': 'error',
+		'no-whitespace-before-property': 'warn',
+		'object-curly-spacing': 'warn',
+		'object-property-newline': ['error', {allowAllPropertiesOnSameLine: true}],
+		'prefer-arrow-callback': 'error',
+		'prefer-const': 'warn',
+		'prefer-spread': 'error',
+		'semi': ['error', 'never'],
+		'space-before-blocks': 'warn',
+		'space-in-parens': 'warn',
+		'template-curly-spacing': ['warn', 'never'],
+		'@typescript-eslint/quotes': ['error', 'single'],
+		'yoda': ['error', 'never', {exceptRange: true}],
+
+		'react/display-name': 'off',
+		'react/no-unescaped-entities': ['error', {forbid: ['>', '}']}],
+		'react/no-children-prop': 'off',
+		'react-hooks/rules-of-hooks': 'error',
+		'react-hooks/exhaustive-deps': 'warn',
+
+		'@xivanalysis/no-unused-dependencies': 'error',
+	},
+
+	overrides: [
+		{
+			files: ['**/*.ts?(x)'],
+			// Empty override so --ext doesn't need to be passed on the CLI - eslint will
+			// include anything matching overrides
+
+			// TODO: Reevaluate and remove these. These disables are simply to get the build green
+			// for the primary tooling PR, and stem from rule mismatch and poor tooling with the
+			// previous tslint harness.
+			rules: {
+				'no-else-return': 'off',
+				'no-magic-numbers': 'off',
+				'brace-style': 'off',
+				'indent': 'off',
+				'semi': 'off',
+				'prefer-arrow-callback': 'off',
+				'no-multiple-empty-lines': 'off',
+				'array-bracket-spacing': 'off',
+				'key-spacing': 'off',
+				'space-in-parens': 'off',
+				'curly': 'off',
+				'linebreak-style': 'off',
+				'no-duplicate-imports': 'off',
+				'space-before-blocks': 'off',
+				'block-spacing': 'off',
+				'keyword-spacing': 'off',
+				'@typescript-eslint/quotes': 'off',
+				'react-hooks/rules-of-hooks': 'off',
+				'react-hooks/exhaustive-deps': 'off',
+			},
+		},
+		// Test files
+		{
+			files: ['**/*.test.js', '**/__tests__/*.js'],
+			env: {jest: true},
+			plugins: ['jest'],
+			rules: {
+				'jest/no-disabled-tests': 'warn',
+				'jest/no-focused-tests': 'error',
+				'jest/no-identical-title': 'error',
+				'jest/prefer-to-have-length': 'warn',
+				'jest/valid-expect': 'error',
+			},
+		},
+	],
+}

.linguirc.json

@@ -0,0 +1,8 @@
+{
+	"srcPathDirs": [
+		"src"
+	],
+	"fallbackLocale": "en",
+	"sourceLocale": "en",
+	"format": "minimal"
+}