This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
feat: update regex to only apply to symbols #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patbl
reviewed
Jan 9, 2020
| @@ -10,7 +10,7 @@ exports.activate = function(context) { | |||
| const document = editor.document; | |||
|
|
|||
| if (editor && document.languageId === "ruby" || document.languageId === "haml" || document.languageId === "erb") { | |||
| const pattern = /:?(["|']?(\w[^\w\s]?)+["|']?)+\s*?=>\s*/g | |||
| const pattern = /[\d|:((\w[^\w\s]?))]+\s*?=>\s*/g | |||
There was a problem hiding this comment.
When I paste it into a JavaScript console, I get a syntax error:
/[\d|:((\w[^\w\s]?))]+\s*?=>\s*/g
VM270:1 Uncaught SyntaxError: Invalid regular expression: /[\d|:((\w[^\w\s]?))]+\s*?=>\s*/: Unmatched ')'
at <anonymous>:1:1
Also, the Ruby code in your example here is syntactically invalid, since you can't use numbers as keys in Ruby hashes with the colon syntax:
[1] pry(main)> { 1: :lol }
SyntaxError: unexpected ':', expecting =>
{ 1: :lol }
There was a problem hiding this comment.
I'll admit I've not used Ruby for almost two years now, but the syntax I'm using in my examples all worked fine when I was testing, which is why I'm confused by all of this.
I'll gladly accept contributions if you have a better solution in mind.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #4