Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for MAG fishing #122

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

PR for MAG fishing #122

wants to merge 40 commits into from

Conversation

bioinfwithjudith
Copy link
Contributor

This is a draft. I would like to add a description on the paper from where this data came from. I had some issues along the way and might be worth noting for new users.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (1b9297b) to head (edb95cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files          11       11           
  Lines        1080     1080           
=======================================
  Hits          920      920           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkoslicki
Copy link
Member

Thanks! Let me know when it's ready for review

@bioinfwithjudith
Copy link
Contributor Author

Updated description for README.md

Question:
NCBI accession: PRJNA924243 and has >50 MAG samples. Currently, the README.md instructs to concatenate these MAGS to work as input for YACHT.

  • Should we keep as is?
  • Would it be worth developing a script that runs YACHT on multiple MAG samples? (might need some direction for this)
  • Should we just run it on one of these MAG samples?

Copy link

sonarcloud bot commented Jun 27, 2024

@dkoslicki
Copy link
Member

Hmmm... @bioinfwithjudith I might need a bit more context. What do you mean by "50 MAG samples"? Do you mean MAGs derived from 50 different metagenomes, or 50 different assemblies from a single genome? If the later, then concatenating them would make sense if you wanted to answer "have any of these MAGs shown up in this other sample?", but keeping them separate would be "is this particular MAG occurring in this other sample?" So it just depends on what you are trying to answer

@bioinfwithjudith
Copy link
Contributor Author

bioinfwithjudith commented Jul 1, 2024

@dkoslicki

I see that I am confused.

The paper states "a non-redundant dataset of 58 was compiled, the majority of which (35) belonged to (Alpha- and Gamma-) Proteobacteria" so I am assuming the latter.

I thought I was answering the MAG fishing question but I am not. Ideally, I would want to download the metagenomes sampled for this study, take a MAG and identify the metagenomes that have said MAG.

I have the MAGs downloaded but I am in the process of figuring out how to download metagenomic samples from MG-RAST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants