Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that dataframes are immutable #924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make it clear that dataframes are immutable #924

wants to merge 1 commit into from

Conversation

dmcg
Copy link

@dmcg dmcg commented Oct 16, 2024

No description provided.

@zaleslaw
Copy link
Collaborator

Thanks for suggestion @dmcg ! We will revisit our examples of code and see how better to say about immutability!

Jolanrensen
Jolanrensen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does mention "immutable", right above this example part, haha. But it doesn't hurt to change it like this. People often only look at examples and recommending to put DataFrame operation results in a new variable does hint at them being immutable.

Jolanrensen
Jolanrensen reviewed Oct 28, 2024
View reviewed changes
docs/StardustDocs/topics/overview.md

// add column
df.add("birthYear") { 1912 - age }
val withBirthYearColumen = df.add("birthYear") { 1912 - age }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Oct 28, 2024
@Jolanrensen Jolanrensen added this to the Docs infrastructure milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolanrensen Jolanrensen Jolanrensen approved these changes

@koperagen koperagen Awaiting requested review from koperagen

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Milestone
Docs infrastructure
Development

Successfully merging this pull request may close these issues.
3 participants
@dmcg @zaleslaw @Jolanrensen