Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate source set for the shared Blackhole #207

Merged
merged 2 commits into from
May 10, 2024

Conversation

qurbonzoda
Copy link
Contributor

The CommonBlackhole class is going to be hidden/internalized. Once it is internal, the public Js and WasmJs Blackhole classes won’t be able to inherit from it. This separate source set, shared btw Js and WasmJs, ensures that the targets have a shared implementation, allowing the CommonBlackhole class to be properly internalized or dropped.

The CommonBlackhole class is going to be hidden/internalized. Once it is internal, the public Js and WasmJs Blackhole classes won’t be able to inherit from it. This separate source set, shared btw Js and WasmJs, ensures that the targets have a shared implementation, allowing the CommonBlackhole class to be properly internalized or dropped.
@fzhinkin fzhinkin self-requested a review May 7, 2024 10:05
@@ -4,6 +4,7 @@ import kotlinx.benchmark.internal.KotlinxBenchmarkRuntimeInternalApi

private const val MAGIC_SIZE: Int = 13

// TODO: Drop this class once it becomes internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: TODOs should have an issue reference, e.g. // TODO KT-1234 ....

Adding an issue ref helps make sure the TODO isn't forgotten. The issue also provides a place for quickly updating the status of the TODO, which can be really helpful when developing in the future (e.g. if I discover a TODO and see the issue is closed as no-longer-needed, then I can be confident in deleting the TODO).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO is part of the @KotlinxBenchmarkRuntimeInternalApi. I have mentioned the need to drop the APIs that are unused after they become internal here: #211

@qurbonzoda qurbonzoda merged commit 4c7af65 into master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants