Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer make Month and DayOfWeek type aliases on the JVM #378

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dkhalanskyjb
Copy link
Collaborator

Fixes #96

Copy link
Member

@ilya-g ilya-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we discussed this change, but cannot find the document.

core/jvm/test/ConvertersTest.kt Outdated Show resolved Hide resolved
core/jvm/test/ConvertersTest.kt Show resolved Hide resolved
@dkhalanskyjb
Copy link
Collaborator Author

I actually don't remember us discussing this change. We mentioned this issue recently while discussing UUIDs and whether to make them type aliases on the JVM.

If you have doubts about this change, we can hold a meeting. What led me to go and implement this is that expect enums in common code are still non-exhaustive, which I think looks extremely strange.

@ilya-g
Copy link
Member

ilya-g commented Apr 19, 2024

Yes, there are some arguments for this change, like exhaustiveness of matching over expected enum entries and being able to provide companion for static extensions (though these shortcomings will be eventually fixed in Kotlin). On the other hand, this is a binary breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't typealias Month (and others)
2 participants