Annotate Instant with @JsExport #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function Instant.toEpochMillisecondsDouble() has been added to allow usage from JS code.
Add annotation targets and retention policies to SafeJsExport for both JS and WASM targets. This ensures consistent annotation behavior across different platforms.
|
This will affect everyone using datetime, even the ones not using This is what you need: https://youtrack.jetbrains.com/issue/KT-64813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class
Instanthas been annotated with@JsExportto allow usage of it from JS code. Due to KT-62385 @JsExport doesn't play well with the WasmTarget, a workaround has been added as well.