Added preserve_border argument to lossless method. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by a better more generalistic method later. Added noexcept optimization on _nogil functions (maybe risky?).
…eger_array_cython
bwoodsend
reviewed
Oct 21, 2024
bwoodsend
approved these changes
Oct 22, 2024
|
Nice! One day we probably should introduce some optional sanitization that asserts all faces are between |
|
I'll merge it then! But for the sanitization I'm not so sure, cause in practice - for any mesh- it would be possible to append as much vertices as we want. As long as they are not referenced by the faces they are "inactive" in some sense, but would not break it. So we could have more vertices than the max value in faces. I don't know how the simplification script would react to this kind of input though. I guess we need to create more thorough tests to be sure about how to handle those cases. For now users will have to deal with their potential segfaults ! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the small change to the cpp function to accept the preserve_border argument, hope it is as straightforward than that, but seems to work.
Also was thinking about saving the bunny as a ".npy" file to remove the need to use trimesh for the tests. Also maybe generate a non watertight mesh (tilted cylinder with open lid or something), to do some more extensive testing for the preserve_border option, but that may be some more work to generate all that using numpy.