-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication][Core] Free degrees of freedom between stages #13099
base: master
Are you sure you want to change the base?
Conversation
…y put the water pressure on 0.0 to gain understanding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Richard, thank you very much for the clear, documented and tested changes. As I told Copilot cannot improve your scripts. ;)
applications/GeoMechanicsApplication/tests/dirichlet_release/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Richard, thank you for changes. The PR is good to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clear and well-tested fix to me. I have several minor suggestions, none of them being blocking. Thanks for the the work you've put into this.
applications/GeoMechanicsApplication/tests/dirichlet_release/MaterialParameters.json
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/ProjectParameters_stage1.json
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/ProjectParameters_stage1.json
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/ProjectParameters_stage1.json
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/ProjectParameters_stage1.json
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/ProjectParameters_stage2.json
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/dirichlet_release/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_dirichlet_release.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_dirichlet_release.py
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/processes/test_apply_constant_scalarvalue_process.cpp
Outdated
Show resolved
Hide resolved
@KratosMultiphysics/technical-committee This PR aims to fix the issue that was discussed earlier (for reference see the discussion in #12454). Feel free to only review the changes made in core (the changes in geo are reviewed within the team, but of course feedback is always welcome). |
…ees-of-freedom-between-stages
@KratosMultiphysics/technical-committee Would it be possible to have a look at this PR? We have discussed the problem before in #12454 (see comments) and it's a bug that impacts our geomechanics workflow. PS. the |
📝 Description
This PR aims to make the C++ process
ApplyConstantScalarValueProcess
more aligned to the python equivalents by releasing degrees of freedom after a stage. A unit test is added, as well as a documented integration test in the GeoMechanicsApplication to show the Dirichlet boundary condition is released in a second stage.