Fluid flux output computation similar to the one in CalculateRHS. #13159
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelov208
previously approved these changes
Feb 21, 2025
applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp
Show resolved
Hide resolved
…de English error text, renamed variable to be consistent.
rfaasse
reviewed
Feb 21, 2025
|
|
||
| auto relative_permeability_values = this->CalculateRelativePermeabilityValues( | ||
| GeoTransportEquationUtilities::CalculateFluidPressures(Variables.NContainer, Variables.PressureVector)); | ||
| const auto fluid_pressures = GeoTransportEquationUtilities::CalculateFluidPressures( |
There was a problem hiding this comment.
Is it possible to unit-test this behavior?
| auto relative_permeability_values = | ||
| CalculateRelativePermeabilityValues(GeoTransportEquationUtilities::CalculateFluidPressures( | ||
| Variables.NpContainer, Variables.PressureVector)); | ||
| const auto fluid_pressures = GeoTransportEquationUtilities::CalculateFluidPressures( |
There was a problem hiding this comment.
Good catch, I fear this was introduced in the refactor efforts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The output item FLUID_FLUX_VECTOR did not take the Bishop coefficient for partial saturation into account. This has been corrected, such that now the flux computation is the same as when forming the RHS.