Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consoleplugin reconciler #884

Merged
merged 12 commits into from
Oct 8, 2024

OPERATOR_NAMESPACE makefile variable for make run target

8121712
Select commit
Loading
Failed to load commit list.
Merged

consoleplugin reconciler #884

OPERATOR_NAMESPACE makefile variable for make run target
8121712
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 1s

81.18% (+0.97%) compared to ece13e8

View this Pull Request on Codecov

81.18% (+0.97%) compared to ece13e8

Details

Codecov Report

Attention: Patch coverage is 76.13636% with 84 lines in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (ece13e8) to head (8121712).
Report is 223 commits behind head on main.

Files with missing lines Patch % Lines
controllers/fake/manager.go 22.22% 28 Missing ⚠️
pkg/library/reconcilers/deployment.go 0.00% 19 Missing ⚠️
controllers/consoleplugin_reconciler.go 81.25% 8 Missing and 4 partials ⚠️
controllers/state_of_the_world.go 26.66% 9 Missing and 2 partials ⚠️
controllers/fake/event_recorder.go 0.00% 6 Missing ⚠️
controllers/fake/api_reader.go 0.00% 4 Missing ⚠️
pkg/library/gatewayapi/utils.go 25.00% 0 Missing and 3 partials ⚠️
pkg/library/utils/crd.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   80.20%   81.18%   +0.97%     
==========================================
  Files          64      115      +51     
  Lines        4492     7420    +2928     
==========================================
+ Hits         3603     6024    +2421     
- Misses        600      967     +367     
- Partials      289      429     +140     
Components Coverage Δ
api/v1beta1 (u) 90.90% <100.00%> (+19.48%) ⬆️
api/v1beta2 (u) 86.61% <81.94%> (-4.82%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.55% <ø> (+6.09%) ⬆️
controllers (i) 82.01% <84.52%> (+5.21%) ⬆️
Files with missing lines Coverage Δ
controllers/fake/manager_builder.go 100.00% <100.00%> (ø)
controllers/test_common.go 100.00% <100.00%> (ø)
controllers/topology_reconciler.go 76.31% <100.00%> (ø)
pkg/envoygateway/utils.go 71.42% <100.00%> (ø)
pkg/istio/utils.go 79.16% <100.00%> (ø)
pkg/openshift/consoleplugin/common.go 100.00% <100.00%> (ø)
pkg/openshift/consoleplugin/consoleplugin.go 100.00% <100.00%> (ø)
pkg/openshift/consoleplugin/deployment.go 100.00% <100.00%> (ø)
pkg/openshift/consoleplugin/nginx_configmap.go 100.00% <100.00%> (ø)
pkg/openshift/consoleplugin/service.go 100.00% <100.00%> (ø)
... and 9 more

... and 59 files with indirect coverage changes