Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: keep namespace in manager.yaml and remove from helm overlay #934

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 10, 2024

Updates changes merged in #904

@eguzki eguzki requested a review from mikenairn October 10, 2024 15:33
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (63f1d28) to head (b91a9f0).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   81.49%   81.61%   +0.11%     
==========================================
  Files         102      115      +13     
  Lines        7177     7700     +523     
==========================================
+ Hits         5849     6284     +435     
- Misses        898      983      +85     
- Partials      430      433       +3     
Flag Coverage Δ
bare-k8s-integration 9.66% <ø> (+0.77%) ⬆️
controllers-integration 71.82% <ø> (+6.49%) ⬆️
envoygateway-integration 49.13% <ø> (-1.17%) ⬇️
gatewayapi-integration 14.56% <ø> (+0.16%) ⬆️
istio-integration 51.52% <ø> (-2.00%) ⬇️
unit 30.55% <ø> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.90% <ø> (ø)
api/v1beta2 (u) 86.61% <ø> (ø)
pkg/common (u) 88.13% <ø> (ø)
pkg/istio (u) 71.51% <100.00%> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.00% <ø> (-0.84%) ⬇️
controllers (i) 82.82% <81.98%> (-0.24%) ⬇️

see 11 files with indirect coverage changes

@eguzki eguzki merged commit 2ece035 into main Oct 10, 2024
33 checks passed
@eguzki eguzki deleted the helm-consistent-with-other-operators branch October 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants