Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.11 quick start and docs #938

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

maleck13
Copy link
Collaborator

fixes and updates for the installation docs
Changes to the observability resources
No code or image changes

…o longer created with istio being installed by sail

Signed-off-by: R-Lawton <[email protected]>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v0.11.0@bde7765). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.11.0     #938   +/-   ##
==================================================
  Coverage                   ?   81.19%           
==================================================
  Files                      ?       89           
  Lines                      ?     6940           
  Branches                   ?        0           
==================================================
  Hits                       ?     5635           
  Misses                     ?      886           
  Partials                   ?      419           
Flag Coverage Δ
bare-k8s-integration 6.78% <ø> (?)
controllers-integration 72.82% <ø> (?)
envoygateway-integration 49.55% <ø> (?)
gatewayapi-integration 12.39% <ø> (?)
istio-integration 53.48% <ø> (?)
unit 28.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <0.00%> (?)
api/v1beta2 (u) 81.25% <0.00%> (?)
pkg/common (u) 88.13% <0.00%> (?)
pkg/istio (u) 71.51% <0.00%> (?)
pkg/log (u) 94.73% <0.00%> (?)
pkg/reconcilers (u) ∅ <0.00%> (?)
pkg/rlptools (u) 85.39% <0.00%> (?)
controllers (i) 82.46% <0.00%> (?)

@R-Lawton
Copy link
Contributor

/lgtm

@maleck13
Copy link
Collaborator Author

The bundle is marked as failing, but I don't think we want this changing so ignoring

name: redis-config
'

kubectl wait limitador/limitador -n kuadrant-system --for="condition=Ready=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verify-bundle check is failing because the auto-generated bundle is not the one commited. To fix that, and makes sense for the release-v0.11.0 branch, update default values of the dependencies:

patch -p1 -N <<EOF
diff --git a/Makefile b/Makefile
index 36dd554..2558a99 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,7 @@ CONTAINER_ENGINE ?= docker
 # To re-generate a bundle for another specific version without changing the standard setup, you can:
 # - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2)
 # - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
-VERSION ?= 0.0.0
+VERSION ?= 0.11.0
 
 # CHANNELS define the bundle channels used in the bundle.
 # Add a new line here if you would like to change its default config. (E.g CHANNELS = "candidate,fast,stable")
@@ -100,7 +100,7 @@ KUADRANT_NAMESPACE ?= kuadrant-system
 # Kuadrant component versions
 ## authorino
 #ToDo Pin this version once we have an initial release of authorino
-AUTHORINO_OPERATOR_VERSION ?= latest
+AUTHORINO_OPERATOR_VERSION ?= 0.13.0
 authorino_bundle_is_semantic := $(call is_semantic_version,$(AUTHORINO_OPERATOR_VERSION))
 
 ifeq (latest,$(AUTHORINO_OPERATOR_VERSION))
@@ -120,7 +120,7 @@ endif
 AUTHORINO_OPERATOR_BUNDLE_IMG ?= quay.io/kuadrant/authorino-operator-bundle:$(AUTHORINO_OPERATOR_BUNDLE_IMG_TAG)
 ## limitador
 #ToDo Pin this version once we have an initial release of limitador
-LIMITADOR_OPERATOR_VERSION ?= latest
+LIMITADOR_OPERATOR_VERSION ?= 0.11.0
 limitador_bundle_is_semantic := $(call is_semantic_version,$(LIMITADOR_OPERATOR_VERSION))
 ifeq (latest,$(LIMITADOR_OPERATOR_VERSION))
 LIMITADOR_OPERATOR_BUNDLE_VERSION = 0.0.0
@@ -138,7 +138,7 @@ endif
 LIMITADOR_OPERATOR_BUNDLE_IMG ?= quay.io/kuadrant/limitador-operator-bundle:$(LIMITADOR_OPERATOR_BUNDLE_IMG_TAG)
 
 ## dns
-DNS_OPERATOR_VERSION ?= latest
+DNS_OPERATOR_VERSION ?= 0.6.0
 
 kuadrantdns_bundle_is_semantic := $(call is_semantic_version,$(DNS_OPERATOR_VERSION))
 ifeq (latest,$(DNS_OPERATOR_VERSION))
@@ -157,7 +157,7 @@ endif
 DNS_OPERATOR_BUNDLE_IMG ?= quay.io/kuadrant/dns-operator-bundle:$(DNS_OPERATOR_BUNDLE_IMG_TAG)
 
 ## wasm-shim
-WASM_SHIM_VERSION ?= latest
+WASM_SHIM_VERSION ?= v0.6.0
 shim_version_is_semantic := $(call is_semantic_version,$(WASM_SHIM_VERSION))
 
 ifeq (true,$(shim_version_is_semantic))
EOF

Additionally, please make sure the doc changes for this branch also land in main branch.

@maleck13
Copy link
Collaborator Author

Thanks @eguzki PR for main is in place #939

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@eguzki
Copy link
Contributor

eguzki commented Oct 14, 2024

we have some flaky tests regarding authorization policy. Re-running it should fix this.

@maleck13 maleck13 merged commit 27c62ff into release-v0.11.0 Oct 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants