Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for kubernetes subjectAccessReview with resource attributes #628

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

averevki
Copy link
Contributor

  • Add Rule and ResourceAttributes dataclasses, and use them in other tests
  • Add test for the kubernetes subjectAccessReview with resource attributes

Closes #109

@averevki averevki added the Test case New test case label Jan 29, 2025
@averevki averevki requested review from trepel and azgabur January 29, 2025 15:13
@averevki averevki self-assigned this Jan 29, 2025
@averevki averevki force-pushed the subj-access-resource-attrs branch from 2de1f9c to 0f94a38 Compare January 29, 2025 15:18
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I went through the code and it seems ok. Tests executed by flags="-vvv" make ./testsuite/tests/singlecluster/authorino/identity/subject_access_review passed for me.

@trepel trepel merged commit 224ca10 into Kuadrant:main Feb 6, 2025
3 checks passed
@averevki averevki deleted the subj-access-resource-attrs branch February 6, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test case New test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kubernetes SubjectAccessReview test
2 participants