Fix user filter where clause and nulldate not being nulldate for bann… #9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xillibit
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Change: categories part one * Change: enable toggle buttons on categories * Change: enable toggle buttons on categories * Change: refactor toolbar * Change: levels filtering + J5 sorting categories * [K6.3] Fix user filter where clause and nulldate not being nulldate for bann… (#9632) * Fix user filter where clause and nulldate not being nulldate for banned users * changed on / off to yes / no as that makes more sense in the filter (imo) * quick fix on nulldate check * cleanup * [K6.3] Change: refactored logs back-end view into J5 (#9628) * Change: refactored logs back-end view into J5 * small cleanup * Change: categories part one * Change: enable toggle buttons on categories * Change: enable toggle buttons on categories * Change: refactor toolbar * Change: levels filtering + J5 sorting categories * Fix: conflicting language strings * Oops: build properties should not have been commited: reverting * [K6.3] Fix for operations filter field (not translated) in Log view (#9634) * Change: categories part one * Change: enable toggle buttons on categories * Change: enable toggle buttons on categories * Change: refactor toolbar * Change: levels filtering + J5 sorting categories * Fix: conflicting language strings * Oops: build properties should not have been commited: reverting * Fix: asveorderUrl not set when sortorder was true bu no items to display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
https://www.kunena.org/forum/k-6-3-0-support/168362-kunena-6-3-0-beta2-dev-user-incorrect-filter-options
Summary of Changes
changed the where clause when there as an OR (signature and banned)
Also the original banned where was filtering on $db->nullDate() which is '0000-00-00 00:00:00' but when I check my kunena users table I see that in field banned a nulldate of '1000-01-01 00:00:00' is used (so not the $db nulldate but an own one). I changed the filter to use the 1000-01-01 00:00:00 nulldate instead.
Testing Instructions
test filters and combinations of filters and see if they work