cleanup folders in install script #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el / vi… (Kunena#9637) * Refactor log clean view into modal making log controller / model / view obsolete * Refactor log clean view into modal making log controller / model / view obsolete
…/Kunena-Forum into cleanup-folders-preflight
|
You should exclude the following files because the user could have added things in it : \src\site\template\aurelia\assets\scss\custom.scss |
|
Removed the aurelia directory, |
|
It's \joomla-51-dev-kunena-63-dev\media\kunena\core\js\ |
|
Ok, this PR doesn't remove anything in the [site]/media folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
added preflight folder cleanup. it is safe to remove folders in preflight as these will be then filled with the update or installation of the extension.
ASSUMPTION (!) here is that the site owner did not do any modifications / added files to the folders that are being deleted
It checks for the installed version and when that is above 6.0.0 and below 6.3.0 then the folders are handled.
Testing Instructions
build package with this PR in it and install it, there should not be any errors and everything should be working as it should.
All Kunena provided folders should now be exactly like in the install package without any left over files from previous versions that where not removed.