Hide private attachments from history #9767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripping linebreaks when removing attachment.
Removed Insert private attachment as this doesn't work. Inserted private attachments are still visible for everyone. Buttons are now ok.
Remove all working I think
buttons display fixed and remove individual attachment now possible
Added buttons Is Private and all attachments private Requires adding language constants COM_KUNENA_ATTACHMENT_IS_PRIVATE and COM_KUNENA_ALL_ATTACHMENTS_ARE_PRIVATE added to transifex
hide insert when private is clicked and hide private when insert is clicked for individual attachment and all attachments
changed language constants to existing language constants for private buttons
All buttons should now be hidden as expected.
Hide private attachments when other user replies
HIde private attachments from historey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9766 .
Summary of Changes
Added code to hide private attachments from history
Testing Instructions
Create topic with at least one private attachment. Logout and login as another user. Private attachment shouldn't be visible anymore in topic history