Feat#50: user 프로필 조회 기능 구현 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjookang
approved these changes
Oct 18, 2024
| User user = userRepository.findById(userId) | ||
| .orElseThrow(() -> new UserException(UserExceptionErrorCode.USER_NOT_EXIST)); | ||
|
|
||
| return new UserResponseDto(user.getName(), user.getEmail()); |
There was a problem hiding this comment.
Response는 만들어놓은 Builder를 사용해도 될 것 같아요!
| User user = userRepository.findById(userId) | ||
| .orElseThrow(() -> new UserException(UserExceptionErrorCode.USER_NOT_EXIST)); | ||
|
|
||
| // name 업데이트 | ||
| user.changeName(newName); | ||
| } | ||
| @Transactional(readOnly = true) | ||
| public UserResponseDto getUserNameAndEmailById(Long userId) { | ||
| User user = userRepository.findById(userId) |
There was a problem hiding this comment.
User user = userRepository.findById(userId)
.orElseThrow(() -> new UserException(UserExceptionErrorCode.USER_NOT_EXIST));
이 부분이 서비스 메서드마다 있는데, 하나의 메소드로 리팩토링해보는 건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50
Issue Define
Summary of resolutions or improvements
Note