Refactor moviepreference #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty big change here.
Main difference is that a user's
MoviePreferences are added at page load. All endpoints that query movies (search, explore, etc) all returnMovieobjects from TMDB.Another change is that all MoviePreference CRUD APIs have been replaced with an
upsertone. "Liking" a movie for the first time, vs changing a movie from "Like" to "Dislike" (or removing it entirely) all seem like similar operations from the UI, and there's a lot of overhead to need to figure out whether an action should cause an insert or update. We had no way to remove preferences, and I think that's probably ok long-term (our preferences can just keep track of a "neutral" state).