allow scrolling props.parent instead of on window only

[borisnadion]

usefull for https://github.com/seatgeek/react-infinite/
related to seatgeek/react-infinite#47

[KyleAMathews]

Cool! Curious what your use case is? Also why checkin the compiled code?

[KyleAMathews]

Hey would love to commit this. Please just remove the checked-in dist stuff.

[KyleAMathews]

Also, another question—why make parent a function? Does the parent element change often with react-infinite?

[borisnadion]

Updated ;-) No, it's not changed.

[KyleAMathews]

Thanks! And if you could squash it down to one commit as well everything
looks great now.
On Sat, Jul 25, 2015 at 2:55 PM Boris Nadion [email protected]
wrote:

Updated ;-) Not it's not changed.

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[borisnadion]

done

[borisnadion]

parent has to be a function, we should bind a listener to an existing dom node

[KyleAMathews]

Why does parent have to be a function?

[KyleAMathews]

@borisnadion bumping this, would love to commit this. Why again does parent need to be a function? Why can't it just be the actual DOM node?

[borisnadion]

< ScrollableContent ref="scrollable" ...>
...
</ ScrollableContent>
< Headroom parent={-> @refs.scrollable?.getDOMNode() || window}>...</ Headroom >

because the parent, or actually just source DOM element for measurements can actually be not parent at all, for example position=fixed elements inside scrollable ones look bad on iOS Safari: they're scrolled with a content and then jump to maintain fixed position when scroll is ended

[WickyNilliams]

Allows you to treat the element as a deferred value, i guess.

Is there a danger of memory leaks due to not cleaning up your event handlers, if the element you listen to can change at any moment?

[KyleAMathews]

Parent should always be a function right? so React.PropTypes.func?

[KyleAMathews]

Cool :) makes sense. If you could rebase and address the question I raised, let's get this merged and in a new release.

[WickyNilliams]

Did you see my comment above regarding memory leaks and event listeners?

[KyleAMathews]

@WickyNilliams I did—not sure I understand—if the parent element is removed—wouldn't the event listeners get GCed?

[WickyNilliams]

Older IE will (React supports back to IE8). But I guess that's not such a priority these days haha. Stuck in my old ways :)

[arielsalminen]

Is there anything you need help with? I’d also need this feature in a project I’m working on. :-)

[KyleAMathews]

Released 1.7.0 w/ this PR included! Thanks @borisnadion!