add planReducer unit test

src/actionCreators/index.js

@@ -30,7 +30,6 @@ export const getPlan = () => (dispatch) => {
     (response) => {
       dispatch(success(reducerTypes.GET_PLAN), response);
       dispatch(storePlan(normalize(response.plan, schema.plan)));
-      dispatch(storePlan(normalize(response.plan, schema.plan)));
     },
     (err) => {
       dispatch(error(reducerTypes.GET_PLAN, err.message));

src/api/index.js

@@ -1,16 +1,14 @@
 // import { v4 } from 'node-uuid';
-
-import paginatedFakeAgreements from './fakeAgreements';
-import fakePlanWithAgreement from './fakePlan';
+import { fakeAgreements, fakePlan } from '../tests/intergration/mockData';
 
 const fakeDatabase = {
-  paginatedAgreements: paginatedFakeAgreements,
-  plan: fakePlanWithAgreement,
+  paginatedAgreements: fakeAgreements,
+  plan: fakePlan,
 };
 
 const delay = ms => new Promise(resolve => setTimeout(resolve, ms));
 
-export const fetchAgreements = filter =>
+export const fetchAgreements = filter => (
   delay(500).then(() => {
     switch (filter) {
       case 'all':
@@ -20,12 +18,14 @@ export const fetchAgreements = filter =>
       default:
         throw new Error(`Unknown filter: ${filter}`);
     }
-  });
+  })
+);
 
-export const fetchPlan = () =>
+export const fetchPlan = () => (
   delay(500).then(() => {
     return fakeDatabase.plan;
-  });
+  })
+);
 
 // export const addTodo = (text) =>
 //   delay(500).then(() => {

src/reducers/planReducer.js

@@ -25,10 +25,8 @@ const storePlan = (state, action) => {
 
   return {
     plans: {
-      ...state.plan,
-      [planId]: {
-        ...plan,
-      },
+      ...state.plans,
+      ...plan,
     },
     planIds: handlePlanIds(state, planId),
     pastures: {

src/api/fakeAgreements.js → src/tests/intergration/fakeAgreements.js

@@ -1,3 +1,4 @@
+/* eslint-disable quotes, comma-dangle */
 const paginatedFakeAgreements = {
   "perPage": 10,
   "currentPage": 1,

src/api/fakePlan.js → src/tests/intergration/fakePlan.js

@@ -1,3 +1,4 @@
+/* eslint-disable quotes, comma-dangle */
 const fakePlanWithAgreement = {
   "forestFileId": "RAN077965",
   "agreementStartDate": "2019-01-01T08:00:00.000Z",

src/tests/intergration/mockData.js

@@ -0,0 +1,2 @@
+export { default as fakeAgreements } from './fakeAgreements';
+export { default as fakePlan } from './fakePlan';

src/tests/reducers/planReducer.test.js

@@ -0,0 +1,84 @@
+import { normalize } from 'normalizr';
+import planReducer from '../../reducers/planReducer';
+import { storePlan } from '../../actions/storeActions';
+import * as schema from '../../actionCreators/schema';
+
+const initialState = {
+  plans: {},
+  planIds: [],
+  pastures: {},
+  grazingSchedules: {},
+  ministerIssues: {},
+};
+
+const mockPlanData = {
+  id: 'plan_id',
+  rangeName: 'hello',
+  pastures: [
+    {
+      id: 'pasture_id',
+      name: 'Pasture 1',
+    },
+  ],
+  grazingSchedules: [
+    {
+      id: 'grazing_schedule_id',
+      year: 2018,
+    },
+  ],
+  ministerIssues: [
+    {
+      id: 'minister_issue_id',
+      detail: 'detail',
+    },
+  ],
+};
+
+const mockState = {
+  plans: {
+    plan_id: {
+      id: 'plan_id',
+      rangeName: 'hello',
+      pastures: ['pasture_id'],
+      grazingSchedules: ['grazing_schedule_id'],
+      ministerIssues: ['minister_issue_id'],
+    },
+  },
+  planIds: ['plan_id'],
+  pastures: {
+    pasture_id: {
+      id: 'pasture_id',
+      name: 'Pasture 1',
+    },
+  },
+  grazingSchedules: {
+    grazing_schedule_id: {
+      id: 'grazing_schedule_id',
+      year: 2018,
+    },
+  },
+  ministerIssues: {
+    minister_issue_id: {
+      id: 'minister_issue_id',
+      detail: 'detail',
+    },
+  },
+};
+
+describe('Plan reducer', () => {
+  it('Initialized with the initial state', () => {
+    expect(planReducer(undefined, {})).toEqual(initialState);
+  });
+
+  describe('Handles \'STORE_PLAN\'', () => {
+    it('Correctly stores the plans and related fields with initial state', () => {
+      const normalized = normalize(mockPlanData, schema.plan);
+      expect(planReducer(initialState, storePlan(normalized))).toEqual(mockState);
+    });
+
+    it('Correctly stores the plans and related fields with pre-existing state', () => {
+      const normalized = normalize(mockPlanData, schema.plan);
+      expect(planReducer(mockState, storePlan(normalized))).toEqual(mockState);
+    });
+  });
+});