Tests unitarios para utils y eliminación de los test del ejb

LACNIC · Jan 7, 2025 · 6bf8bd4 · 6bf8bd4
1 parent d390239
commit 6bf8bd4
Show file tree

Hide file tree

Showing 15 changed files with 874 additions and 1,128 deletions.
diff --git a/elections-ejb/src/main/java/net/lacnic/elections/ejb/impl/ElectionsManagerEJBBean.java b/elections-ejb/src/main/java/net/lacnic/elections/ejb/impl/ElectionsManagerEJBBean.java
@@ -81,10 +81,6 @@ public ElectionsManagerEJBBean() {
 		// Default initialization
 	}
 
-	public void setEm(EntityManager em) {
-		this.em = em;
-	}
-
 	/**
 	 * Logs an user to the application and persists audit information in the activity table
 	 * 

diff --git a/elections-ejb/src/main/java/net/lacnic/elections/utils/ExcelUtils.java b/elections-ejb/src/main/java/net/lacnic/elections/utils/ExcelUtils.java
@@ -103,7 +103,7 @@ public static List<UserVoter> processCensusExcel(String contentType, byte[] cens
 		}
 	}
 
-	private static Workbook getWorkbook(String contentType, FileInputStream fis) throws IOException, CensusValidationException {
+	public static Workbook getWorkbook(String contentType, FileInputStream fis) throws IOException, CensusValidationException {
 		switch (contentType) {
 		case CONTENT_TYPE_XLS:
 			return new HSSFWorkbook(fis);
@@ -161,21 +161,21 @@ private static String getOptionalCellValue(Row row, int columnIndex) {
 		return (cell != null) ? cell.getStringCellValue() : null;
 	}
 
-	private static String validateLanguage(String language, int rowIndex) throws CensusValidationException {
+	public static String validateLanguage(String language, int rowIndex) throws CensusValidationException {
 		if (!language.matches("SP|EN|PT")) {
 			throw new CensusValidationException("censusManagementUploadWrongLanguage", rowIndex, language);
 		}
 		return language;
 	}
 
-	private static String validateEmail(String email, int rowIndex) throws CensusValidationException {
+	public static String validateEmail(String email, int rowIndex) throws CensusValidationException {
 		if (!email.contains("@") || !email.contains(".")) {
 			throw new CensusValidationException("censusManagementUploadWrongEmail", rowIndex, email);
 		}
 		return email;
 	}
 
-	private static int validateVoteAmount(Cell cell, int rowIndex) throws CensusValidationException {
+	public static int validateVoteAmount(Cell cell, int rowIndex) throws CensusValidationException {
 		try {
 			int votes = (int) cell.getNumericCellValue();
 			if (votes <= 0) {

diff --git a/elections-ejb/src/main/java/net/lacnic/elections/utils/MailHelper.java b/elections-ejb/src/main/java/net/lacnic/elections/utils/MailHelper.java
@@ -108,12 +108,12 @@ public static boolean sendMail(Session session, String fromString, String to, St
 		}
 	}
 
-	private static String getHeaderMailer(String subject) {
+	public static String getHeaderMailer(String subject) {
 		SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy");
 		return StringUtils.md5(subject.concat(sdf.format(new Date())));
 	}
 
-	private static Address getEmailAddress(String fromString) throws MessagingException, UnsupportedEncodingException {
+	public static Address getEmailAddress(String fromString) throws MessagingException, UnsupportedEncodingException {
 		String[] from = fromString.split(",");
 		if (from.length == 2)
 			return new InternetAddress(from[0], from[1]);