-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for recorded source/mic directivities from DIRPAT database (#259) #302
Open
fakufaku
wants to merge
60
commits into
master
Choose a base branch
from
dev/dirpat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
54ac420
Support for recorded source/mic directivities from DIRPAT database (#…
prerak23 63d13f8
merge with master
fakufaku 4274ec2
remove deprecated np.float type alias from numpy. run black
fakufaku 8853437
isort
fakufaku 02af651
isort
fakufaku 76f8b96
Adds download functions for the SOFA files from DIRPAT. Adds tests fo…
fakufaku 88e1c5b
Adds workaround to CI for windows and py3.7
fakufaku a2e1080
Changes the EM32 sofa file url to official url
fakufaku 2c04a8c
open_sofa_interpolate.py: vectorizes fibonnaci computations, use sphe…
fakufaku 910e5b5
Fixes the weights in the weighted pseudo-inverse used in the interpol…
fakufaku 1a45b7c
Moves SOFA open function out of the DIRPATInterpolate class.
fakufaku 70a562e
Separates the spherical interpolation from the DIRPAT and SOFA classe…
fakufaku b662934
Merge branch 'master' into dev/dirpat
fakufaku 683b498
Vectorizes the spherical harmonics computation function for spherical…
fakufaku 7507118
Moves the regular grid detection function to doa.utils
fakufaku 9f91a55
Changes the DIRPAT terminology to something more general to support m…
fakufaku 079bb1e
black/isort
fakufaku 5958ce0
black/sort
fakufaku b6ff1cb
Adds support sofe simple hrir sofa files
fakufaku f558bfc
Adds two SOFA files for MIT Kemar HRTF. Adds an example script for bi…
fakufaku f76ca8f
merge master
fakufaku bdb8309
Modularize the RIR building routines for ISM and RT
fakufaku 32269ae
Fixing tests for sofa files
fakufaku 92e4007
Adds simulation sub-package in list in setup.py
fakufaku 9b38cca
Adds init file for simulation sub-package
fakufaku 88a9c54
fix sofa test
fakufaku 4922a0e
ray tracing: adds air absorption, linear interpolation of histogram
fakufaku 5ffe18c
Fixes issue when histogram is all zeros
fakufaku 0ab2ad9
Switch to using the origin pyroomacoustics fibonacci spherical grid f…
fakufaku 46e30d1
moves is_dirpat check inside the open sofa file function
fakufaku b0d2b1d
modularize the element location parsing routine for sofa files
fakufaku b4abb9b
adds sofa database as attrdict
fakufaku 3984eaa
black
fakufaku 20e4106
merge master
fakufaku 1c1ddc9
Improved SOFA api
fakufaku cf6802e
example
fakufaku 0edebfb
Fixes the SOFA tests. Due to change of sampling algorithm (scipy.sign…
fakufaku bc016ad
lint
fakufaku e96f4ee
merge
fakufaku b6aa302
relocates the from directivities to simulation/ism
fakufaku 9fb7ba7
fixes source_angle_shoebox test
fakufaku 7874a01
refactors directivities sub-module and sofa sub-module into a single …
fakufaku ccacfed
fixes sofa db to include files that are present, but not in the json …
fakufaku 65107c4
SOFA measurement labels are read from the database when available. Ma…
fakufaku 26f4a32
removes unnecessary imports and lint
fakufaku b1a0357
Merge branch 'master' into dev/dirpat
fakufaku 120ac43
CHANGELOG formatting for branch
fakufaku 1d09fb8
merge
fakufaku f866eb8
Fixes the cardioid family formula in the corresponding object. Adds a…
fakufaku b3917a0
lint
fakufaku d8d79ea
changes the interface for cardioid family. Removes the enum, uses sep…
fakufaku d392bb6
lint
fakufaku d48a899
Changes the KDTree in MeasuredDirectivity from operating on spherical…
fakufaku e845041
Adds directivities (analytic and measured) to the documentation.
fakufaku f89e815
adds soxr to requirements for doc building
fakufaku 8d24c10
Doc
fakufaku d7371a8
Disallow directivities for 2D rooms.
fakufaku 5e1334f
Fixes directivities examples
fakufaku 200e875
lint
fakufaku b6d9a6c
Fixes some docstrings
fakufaku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,7 @@ | |
"mpl_toolkits.mplot3d", | ||
"joblib", | ||
"scipy.io", | ||
"soxr", | ||
] | ||
|
||
try: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
SOFA Database | ||
============= | ||
|
||
.. automodule:: pyroomacoustics.datasets.sofa | ||
:members: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,75 @@ | ||
pyroomacoustics.directivities module | ||
==================================== | ||
Directional Sources and Microphones | ||
=================================== | ||
|
||
.. automodule:: pyroomacoustics.directivities | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
Analytic Directional Responses | ||
------------------------------ | ||
|
||
.. automodule:: pyroomacoustics.directivities.analytic | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
Measured Directivities | ||
---------------------- | ||
|
||
.. automodule:: pyroomacoustics.directivities.measured | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
Built-in SOFA Files Database | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
.. automodule:: pyroomacoustics.datasets.sofa | ||
:members: SOFADatabase, get_sofa_db | ||
:noindex: | ||
|
||
|
||
Reading Other or Custom File Types | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
It is possible to read other file types by providing a custom reader function to | ||
:py:class:`~pyroomacoustics.directivities.measured.MeasuredDirectivityFile` with the | ||
argument ``file_reader_callback``. | ||
The function should have the same signature as :py:func:`~pyroomacoustics.directivities.sofa.open_sofa_file`. | ||
|
||
|
||
SOFA File Readers | ||
................. | ||
|
||
.. automodule:: pyroomacoustics.directivities.sofa | ||
:members: | ||
:show-inheritance: | ||
|
||
Direction of the Patterns | ||
------------------------- | ||
|
||
.. automodule:: pyroomacoustics.directivities.direction | ||
:members: | ||
:show-inheritance: | ||
|
||
|
||
Creating New Types of Directivities | ||
----------------------------------- | ||
|
||
.. automodule:: pyroomacoustics.directivities.base | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
Spherical Interpolation | ||
----------------------- | ||
|
||
.. automodule:: pyroomacoustics.directivities.interp | ||
:members: spherical_interpolation | ||
|
||
Numerical Spherical Integral | ||
---------------------------- | ||
|
||
.. automodule:: pyroomacoustics.directivities.integration | ||
:members: spherical_integral |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
pyroomacoustics.simulation.ism module | ||
===================================== | ||
|
||
.. automodule:: pyroomacoustics.simulation.ism | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Simulation Routines Sub-package | ||
=============================== | ||
|
||
This sub-package contains some internal routines to simulate room acoustics. | ||
|
||
Submodules | ||
---------- | ||
|
||
.. toctree:: | ||
:maxdepth: 4 | ||
|
||
pyroomacoustics.simulation.ism | ||
pyroomacoustics.simulation.rt | ||
|
||
Module contents | ||
--------------- | ||
|
||
.. automodule:: pyroomacoustics.simulation | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
pyroomacoustics.simulation.rt module | ||
==================================== | ||
|
||
.. automodule:: pyroomacoustics.simulation.rt | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For colatitude, shouldn't the "num" be equal to 181?