Remove current record from queue when ignoring it based on negative timestamp #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AlexPorebski , Thanks for your pull request. Can you add one unit test more here (RecordQueueTests.cs) to close this gap ? |
|
Done |
|
Thank you @AlexPorebski for your PR, I merged it. Btw, I'm currently conducting a satisfaction survey to understand how I can better serve and I would love to get your feedback on the product. Thank you for your time and feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we encountered cases when some faulty data is provided in topic.
We wanted to ignore records that we weren't able to properly process but when returning negative values from our TimestampExtractor we enter infinite loop that breaks processing.
Here is fix for this edge case.