Outer steering vector #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattRolchigo
force-pushed
the
outer_steer_vec
branch
from
3f9ea5b to
2d24487
Compare
streeve
requested changes
Apr 25, 2024
streeve
reviewed
Apr 29, 2024
| @@ -26,6 +26,7 @@ struct Inputs { | |||
|
|
|||
| std::string simulation_type = "", material_filename = "", grain_orientation_file = ""; | |||
| unsigned long rng_seed = 0.0; | |||
| int build_increment_outer = 5000; | |||
There was a problem hiding this comment.
This variable name will confuse me - frequency instead of increment would help
streeve
approved these changes
Apr 29, 2024
MattRolchigo
added a commit
to MattRolchigo/ExaCA
that referenced
this pull request
May 14, 2024
This reverts commit 36ab28d.
MattRolchigo
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight performance optimization for problem types with remelting to iterate over an "outer" steering vector (created at a time interval of either 5000 time steps or a user input value) rather than over all cells when creating the main steering vector used for cell capture.