Fix device print usage #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
fix_printf
branch
4 times, most recently
from
29e6816 to
66ba8b9
Compare
|
@streeve is there a way to check the CI for exactly which temperature unit test is failing? I've seen intermittent failure of the unit test but never twice in a row like this |
introduced in version 4.2
Ran fine this time.. we would either need to run the tests with verbose output all the time or add the option to inject it when we want (and hope it fails that time) |
MattRolchigo
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only print with Kokkos::printf (introduced in version 4.2)
Previously broke with SYCL backend