Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant calculations of cell capture face lengths #385

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

MattRolchigo
Copy link
Collaborator

@MattRolchigo MattRolchigo commented Dec 5, 2024

The value triangle_dist calculated during a cell capture event is equivalent to the negative of the critical diagonal length for cell capture - the critical diagonal length can be used in its place, provided that the negative of the grain unit vector values are used to cancel out the sign change

For large problems/small resource sets, and particularly on CPU, this change results in up to a 2% performance improvement. For most problems, the improvement is negligible (1% or less)

@MattRolchigo MattRolchigo requested a review from streeve December 5, 2024 22:32
@MattRolchigo MattRolchigo added the performance Simulation performance related label Dec 6, 2024
@MattRolchigo MattRolchigo merged commit 4a35899 into LLNL:master Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Simulation performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants