feature: Add pipeline to check code formatting #1783
Conversation
johnbowen42
force-pushed
the
feature/bowen/clang-format-ci-pipeline
branch
3 times, most recently
from
16163f8 to
4918545
Compare
johnbowen42
force-pushed
the
feature/bowen/clang-format-ci-pipeline
branch
from
4918545 to
8bc8bb8
Compare
|
Why is the script removed? |
Same question from me. |
|
@johnbowen42 do we need your branch for this PR activated in RTD anymore? |
| // decltype(add.eval(tile))>(left.eval(tile), | ||
| // right.eval(tile), add.eval(tile))) | ||
| ADD_TYPE const& | ||
| add) //-> |
There was a problem hiding this comment.
This change looks odd. Any idea why clang-format did this?
There was a problem hiding this comment.
honestly, no, this one is perplexing
This script was old and is not how we apply clang format now. The consistent way to apply clang format is either with the provided pre-commit git hook or the |
| @@ -71,6 +71,15 @@ RUN cmake -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_OPENMP | |||
| ctest -T test --output-on-failure && \ | |||
| make clean | |||
|
|
|||
| FROM ghcr.io/llnl/radiuss:clang-14-ubuntu-22.04 AS clang14_style | |||
| USER root | |||
There was a problem hiding this comment.
Are we sure we want to specify "root" as the user?
There was a problem hiding this comment.
I'm pretty sure we want to specify root. This is how axom does it https://github.com/LLNL/axom/blob/511ae0ae6fe474448fa7dd5dfe16ae6d91fc47b9/azure-pipelines.yml#L124, because cmake needs write permissions for the files
There was a problem hiding this comment.
Good catch @adayton1 We probably don't want or need that.
|
@johnbowen42 if you don't want yout PR branch anymore, please delete. |
Resolves #1717