Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example in quick-start.md #118

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

riceri
Copy link
Contributor

@riceri riceri commented Jan 3, 2025

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Some example code in the quick-start did not work

@visto9259 visto9259 self-requested a review January 4, 2025 16:21
@visto9259 visto9259 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 4, 2025
Copy link
Member

@visto9259 visto9259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues. Quick fix. Thanks

@visto9259
Copy link
Member

@riceri
Next time, please sign-off your commits. It's again something that should have been in the non yet existing contribution guidelines...

@visto9259 visto9259 merged commit 2110f50 into LM-Commons:2.1.x Jan 4, 2025
1 check passed
@visto9259
Copy link
Member

Thanks @riceri

@visto9259 visto9259 added this to the 2.1.1 milestone Jan 4, 2025
@visto9259
Copy link
Member

@riceri
Since I use Docusaurus for the website and I am using Docusaurus versionning, it turns out that you made the changes to the version that is not being displayed by Docusaurus. I did not catch the issue either and I was trying to figure out why the change was not appearing online.
If you look under the /docs folder, there is a /docs folder where the current version of the docs is and there is a /version_docs folder that contains the 2.0 version which is the version being shown online. The change should have been made in that version.
I forgot about this myself.
If you plan to make changes to LmcRbacMvc as well, let me know and I will provide proper guidance.
Regards

@riceri
Copy link
Contributor Author

riceri commented Jan 4, 2025

@visto9259
Ok, the first change was done from the edit link on the docs it referred to the master branch so that should be changed i guess.

There is some code formatting in the docs that I was thinking on updating in LmcRbacMvc, but also make the LmcUser guide easier to find, I had some problems getting LmcUser and LmcRbacMvc to work until i found that one. In the Intro part of the docs to LmcRbacMvc, LmcUser is talked about but. There I would like a link to the guide how to get LmcUser to work with LmcRbacMvc. So i planed to add that to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants