Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SW and BHKSSW elliptic curve datasets #6267

Merged
merged 18 commits into from
Nov 19, 2024
Merged

Add SW and BHKSSW elliptic curve datasets #6267

merged 18 commits into from
Nov 19, 2024

Conversation

roed314
Copy link
Contributor

@roed314 roed314 commented Nov 18, 2024

Also adds an index page for datasets, and links it from the new access options page. See

@roed314 roed314 added the ECQ Elliptic curves over Q label Nov 18, 2024
@JohnCremona
Copy link
Member

Looks good to me. Two small points: you only list last names for BHKSSW but full names for SW, I suggest just last names for the latter. Also, in the api page I think the wording of "you can install the LMFDB locally" is misleading! People may think that this gives them all the data locally. Perhaps insert "web frontend" after "LMFDB"? ALso possibly add a phrase making it 100% clear that the frontend you install will connect to the same SQL database as the main one.

@roed314
Copy link
Contributor Author

roed314 commented Nov 18, 2024

I've made the two changes John suggested (the second one through this knowl). I also added a statement adding that we ask for a CC-BY-SA license for contributions. If the managing editors don't agree with that requirement, let me know!

It would be nice to have links in the "Source" column for zeta zeros and congruent numbers. I wasn't able to find any links that were as good as the other three rows; I'd welcome suggestions from someone who knows more about the history of these datasets. For Zeta zeros, wikipedia has a stub on ZetaGrid, which links to a paper that might be reasonable but it looks like the author of that paper probably wasn't the person who computed our data. For congruent numbers, I wasn't able to find any appropriate papers by Randall L. Rathbun.

@jwj61
Copy link
Member

jwj61 commented Nov 19, 2024

Just a tiny quibble. On the conditions at the end, all 3 are set up at continuations of the phrase "In order to be considered for inclusion, your dataset should", so they should not start with a capital letter, the second should not end in a period, I think commas are more appropriate than semicolons, and the third one is not parallel (currently: In order to be considered for inclusion, your dataset should Be willing to release your data under the ...).

@roed314
Copy link
Contributor Author

roed314 commented Nov 19, 2024

@jwj61 Fixed.

@jwj61 jwj61 merged commit b495bc2 into LMFDB:main Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECQ Elliptic curves over Q
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants