SlicerT reversed slices and bug fixes #6992
Conversation
|
Wouldn't it better for reversed slices to be opt-in for each slice, rather than playing slices in reverse below the root? This would probably mean more infrastructure changes to your plugin, but I'm curious what you think. |
Of course, the ideal version of this plugin would let you modify every individual slice, but this seems like a good compromise for the moment. The keys were unused anyway, so this way they at least have some use. |
So this is a stopgap for better functionality that may come later? My concern is whether this could create difficulties in implementing future functionality in a backwards compatible way. If it may be an issue, we should probably wait until the new functionality is fully ready and just merge the bug fixes now. |
I don't really think this is only a stopgap, the keys aren't going to have any extra use in the future, so might as well have them act as the reverse. Also, it'll be a while until I start working on new functionality, since like I said I need the sample buffer PR and aubio. Once I do there won't be any keys with functionality, so this will be preserved. Of course there is no problem removing it for now, I just wanted to add it since it was requested in the original PR. |
|
It now has conflicts that needs resolving. I think this adds great value to SlicerT. |
| @@ -143,8 +142,7 @@ void SlicerT::playNote(NotePlayHandle* handle, sampleFrame* workingBuffer) | |||
| workingBuffer[i + offset][1] *= fadeValue; | |||
| } | |||
|
|
|||
| instrumentTrack()->processAudioBuffer(workingBuffer, frames + offset, handle); | |||
|
|
|||
There was a problem hiding this comment.
I removed the two lines above in #7174
|
I think the bug fixes and the reversed slices should be two separate PRs. Then the bug fixes can be merged quickly while we take time to consider how we want to implement reversed samples or other features. |
Yes, I agree. |
|
Just a heads up...there is another slicert PR in the pipeline: #7453 |
|
@DanielKauss update on the bugfix? If you can seperate the bugfix, I'll consider fast tracking the fixes. I'm considering to merge #7453, hope there's no merge conflicts. |
|
Ohh ok then. |
Fixes the bugs mentioned by @zonkmachine in #6857 and adds reversed slices below the base note. Backwards compatibility should be preserved.
Here is an example, the selected notes get played in reverse: