MSVC: Always use Win32 ANSI functions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes here, but allows building veal regardless of whether the UNICODE macro is set
messmerd
changed the title
A functions
|
Would that make sense on upstream? If yes, I would rather suggest to do it there, and then merge upstream? |
|
@JohannesLorenz I just opened a PR upstream: calf-studio-gear#362 |
|
@messmerd @JohannesLorenz how do you want to sync this into our branch? Commit it directly, cherry-pick it or fast forward everything from upstream? It's one of just a few remaining blockers for: If fast-forward is the preference, I'd kindly ask @JohannesLorenz to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes here, but allows building veal regardless of whether the
UNICODEmacro is defined