MP3 audio startup silence should be set according to track sample rate #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, as silence inserted at the beginning will be at 44.1, player will set for 44.1 and if track uses another rate, it will be misplayed
non-lazy version
it's a valid request to disable all redirection but the use of the || operator disallows it
mherger
force-pushed
the
public/8.3
branch
2 times, most recently
from
6a78514
to
bc6b853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://forums.slimdevices.com/showthread.php?114921-piCorePlayer-Radio-is-streamed-with-wrong-frequency, when silence is added according to "audio startup time", it should be with the track's sampling frequency. If not possible, ignore startup silence otherwise player will use wrong sample rate.