Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Org Chart UI to migrate it from azure to Choreo #26

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Update Org Chart UI to migrate it from azure to Choreo #26

wants to merge 15 commits into from

Conversation

vish-mv
Copy link

@vish-mv vish-mv commented Sep 12, 2024

Purpose

Migrate org chat ui deployment from currently deployed azure to Choreo

Changes made

  • Update the alpine version because Choreo doesn't support existing version
  • Update the server URL to Choreo deployed URL
  • Removed public react app URL
  • Added a non root user to the docker
  • Added new paths for the nginx config and set permission access to those path in the Dockerfile

Nirhoshan
Nirhoshan reviewed Sep 12, 2024
View reviewed changes
Dockerfile Outdated
# ENV REACT_APP_API_BASE_URL=http://localhost:8000
ARG SERVER_URL=http://localhost:9000/
ARG PUBLIC_URL=http://localhost:9000/
ARG SERVER_URL=https://f2c7f522-ef47-48ce-a429-3fc2f15d2011-copilote1.e1-us-east-azure.choreoapis.dev/ldf/gig-backend/v1/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the URL as an environment variable to fetch while deploying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirhoshan Nirhoshan Nirhoshan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vish-mv @Nirhoshan