Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data registry to access paths and save pipeline runs #93

Merged
merged 20 commits into from
Nov 17, 2023

Conversation

joezuntz
Copy link
Collaborator

@joezuntz joezuntz commented Jul 17, 2023

This adds an interface to the data registry. We want to:

  • Get paths to overall_input in yaml files using a direct lookup of a file by ID or name.
  • Support looking up a file from a specific user or project.
  • Support lookup by alias when ready.
  • Support getting an input using its tag and a previous execution lookup.
  • Add a way to save an execution entry from an entire pipeline run and its outputs.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (25def53) 89.81% compared to head (a7f921d) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   89.81%   89.66%   -0.16%     
==========================================
  Files          16       16              
  Lines        1709     1722      +13     
==========================================
+ Hits         1535     1544       +9     
- Misses        174      178       +4     
Files Coverage Δ
ceci/pipeline.py 84.88% <73.33%> (-0.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartmcalpine
Copy link
Contributor

I have updated the registry setup to the latest dataregistry interface syntax.

One technicality is during data_registry_lookup you can search for a dataset by name, and check it is unique. names dont have to be unique in the registry, name + version does, so we can come back to that

@joezuntz joezuntz merged commit ca433c1 into master Nov 17, 2023
12 of 14 checks passed
@joezuntz joezuntz deleted the data-registry branch November 17, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants