Issue/8/improve informer and estimator parameter setting #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2024 22:50
zmode doesnt seem to be added to output. Still questions over what stages should go in the inform or estimate stage
Still issues with params. Performance seems comparable to BPZ. Added example notebook.
This allows overwriting through the inform or estimate init
…issue/8/improve-informer-and-estimator-parameter-setting
drewoldag
approved these changes
Apr 5, 2024
drewoldag
deleted the
issue/8/improve-informer-and-estimator-parameter-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some config settings from the functions to ceci param objects in the class config. this will allow them to be overwritten during inform or estimate stages. We still depend on the lephare txt param files which we might want to replace with a yaml file which would load directly into a keymap.
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added