Create test for algos #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is minimum imports and data required for test golden spike uncitonality
raphaelshirley
changed the title
|
What are the minimum tests we need to do for inform and estimate? |
drewoldag
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
This looks good to me, @raphaelshirley can you take a look at my changes and approve/reject?
|
Great thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is minimum imports and data required for test golden spike funcitonality? In order to run the estimator we need a test data set. We can get this from the RAIL directories but will that run on gitHub?
Closes #7
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added